This repository has been archived by the owner on Feb 8, 2021. It is now read-only.
start qemu in non-blocking mode #691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jimoosciuc ! We do not preallocate guest memory when launching qemu. Are you sure it is the large guest memory that caused startup timeout in your case? Also we handle qemu startup timeout when initializing the qmp handler. If it takes 1-2 minutes to start qemu, the qmp initializer should fail. So are you just trying to avoid qemu residue instead of making it work to launch large memory guests? |
|
Yes, in the experiment, when we gradually increase the memory size, the qemu startup time will increase. Now we have set the timeout to 60s, but this works only under 120G memory. When using larger memory, Will cause qemu residue. In our practice, changing to a non-blocking start does solve this problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our experiments, we often need very large memory, such as 256G. When the resource demand is very large, qemu starts slowly. In some cases, it may take 1 to 2 minutes. If the startup timeout, starting qemu in a blocked manner will result in qemu residue, this is because killing qemu will be skipped due to process==nil, so it is recommended to change to non-blocking mode, so the process in QemuContext always has value, can avoid qemu residue